octodns-cloudflare: init at 0.0.9 #383034
Open
+57
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
Defelo
reviewed
Feb 18, 2025
ret2pop
force-pushed
the
ret2pop/octodns-cloudflare
branch
from
f828835 to
b0f4b77
Compare
|
good |
Defelo
reviewed
Feb 23, 2025
| version = "0.0.9"; | ||
| pyproject = true; | ||
|
|
||
| disabled = pythonOlder "3.8"; |
There was a problem hiding this comment.
Suggested change
| disabled = pythonOlder "3.8"; | |
| disabled = pythonOlder "3.9"; |
According to their setup.py this package requries at least Python 3.9
There was a problem hiding this comment.
I squashed the commits and both commit messages are listed in the single squashed commit, so actually there is both the maintainers commit and the package commit squashed into one commit. Also, I now have updated the python version.
octodns-cloudflare: init at 0.0.9 fix python version
ret2pop
force-pushed
the
ret2pop/octodns-cloudflare
branch
from
b0f4b77 to
fd2ba93
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.