Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.django-allauth-2fa: drop #382406

Merged

Conversation

MarcelCoding
Copy link
Member

django-allauth-2fa was unused, incompatible with the currently packaged django-allauth version and django-allauth now supports 2fa itself.

and the release notes encourage to switch to allauth
valohai/django-allauth-2fa#189 (comment)

cc @DerDennisOP

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

django-allauth-2fa was unused, incompatible with the currently packaged
django-allauth version and django-allauth now supports 2fa itself.

> and the release notes encourage to switch to allauth
valohai/django-allauth-2fa#189 (comment)
@DerDennisOP
Copy link
Contributor

LGTM

@nix-owners nix-owners bot requested a review from natsukium February 15, 2025 20:16
@MarcelCoding MarcelCoding mentioned this pull request Feb 15, 2025
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 15, 2025
@wolfgangwalther wolfgangwalther merged commit 504dc57 into NixOS:master Feb 16, 2025
26 of 27 checks passed
@MarcelCoding MarcelCoding deleted the remove-django-allauth-2fa branch February 16, 2025 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants