-
-
Notifications
You must be signed in to change notification settings - Fork 15.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wireplumber.nix: Fixed broken doc link #380161
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jetbrains.aqua: 2024.3.1 -> 2024.3.2 jetbrains.gateway: 2024.3.1.1 -> 2024.3.2 jetbrains.goland: 2024.3.2 -> 2024.3.2.1 jetbrains.idea-community: 2024.3.2 -> 2024.3.2.2 jetbrains.idea-ultimate: 2024.3.2 -> 2024.3.2.2 jetbrains.mps: 2024.1.1 -> 2024.3 jetbrains.phpstorm: 2024.3.2 -> 2024.3.2.1 jetbrains.pycharm-community: 2024.3.1.1 -> 2024.3.2 jetbrains.pycharm-professional: 2024.3.1.1 -> 2024.3.2 jetbrains.rider: 2024.3.3 -> 2024.3.4 jetbrains.ruby-mine: 2024.3.2 -> 2024.3.2.1 jetbrains.rust-rover: 2024.3.3 -> 2024.3.4 jetbrains.webstorm: 2024.3.2 -> 2024.3.2.1 (cherry picked from commit 5de78a6)
(cherry picked from commit d9f46e9)
https://chromereleases.googleblog.com/2025/01/stable-channel-update-for-desktop_28.html This update includes 2 security fixes. CVEs: CVE-2025-0762 (cherry picked from commit 82fb28b)
Diff: jeffvli/feishin@v0.11.1...v0.12.0 Changelog: https://github.com/jeffvli/feishin/releases/tag/v0.12.0 (cherry picked from commit 6ce5063)
Diff: jeffvli/feishin@v0.12.0...v0.12.1 Changelog: https://github.com/jeffvli/feishin/releases/tag/v0.12.1 (cherry picked from commit cb20f06)
(cherry picked from commit ca840a0)
(cherry picked from commit 37d4584)
(cherry picked from commit ad669d4)
Closes #376820 The issue with providing `moduleMakeFlags` via `passthru` of the kernel package is that when this package gets overriden[1], the `moduleMakeFlags` list still references the kernel without the overrides. This broke e.g. kernel modules of linux-rpi4 which can be reproduced with nix-build --argstr system aarch64-linux -A linuxKernel.packages.linux_rpi4.zfs_2_3 This used to break with Error: modDirVersion 6.6.51 specified in the Nix expression is wrong, it should be: 6.6.51-v8 since KBUILD_OUTPUT referenced the kernel without the changes from `overrideDerivation` that also changes the `modDirVersion`. The new approach is to add the build flags right into `linuxKernel.packages.linux_X_Y`: that way we don't need any hacks to update `moduleMakeFlags` when the derivation with the passthru gets overridden. By using the fixpoint of the package-set, the `kernelModuleMakeFlags` list is correctly updated. E.g. given with import ./. {}; linuxKernel.packages.linux_6_6.extend (self: super: { kernel = super.kernel.overrideAttrs (_: { name = "linux-snens"; }); }) the `makeFlags` is correctly updated: $ nix-instantiate snenskek.nix -A zfs_2_3.makeFlags --eval --strict [ "ARCH=x86_64" "CROSS_COMPILE=" "KBUILD_OUTPUT=/nix/store/gsp68549k1aqbwxwczpgw67w5jjn4shw-linux-snens-dev/lib/modules/6.6.74/build" ] [1] E.g. `linux-rpi4`. (cherry picked from commit 5645cd2)
(cherry picked from commit bb3bba2)
Signed-off-by: Sefa Eyeoglu <[email protected]> Co-authored-by: Simon Gardling <[email protected]> (cherry picked from commit d2145a1)
Signed-off-by: Sefa Eyeoglu <[email protected]> (cherry picked from commit 7bf88be)
Diff: immich-app/immich@refs/tags/v1.123.0...v1.124.2 Changelog: https://github.com/immich-app/immich/releases/tag/v1.124.0 https://github.com/immich-app/immich/releases/tag/v1.124.1 https://github.com/immich-app/immich/releases/tag/v1.124.2 (cherry picked from commit b96bce0)
Diff: immich-app/immich@refs/tags/v1.125.2...v1.125.3 Changelog: https://github.com/immich-app/immich/releases/tag/v1.125.3 (cherry picked from commit 0b73be7)
Diff: immich-app/immich@refs/tags/v1.125.6...v1.125.7 Changelog: https://github.com/immich-app/immich/releases/tag/v1.125.7 (cherry picked from commit 36616cf)
Changelog: https://github.com/psastras/sarif-rs/releases/tag/clippy-sarif-v0.7.0 Diff: psastras/sarif-rs@clippy-sarif-v0.6.6...clippy-sarif-v0.7.0 (cherry picked from commit f3da7ae)
Diff: lsp-plugins/lsp-plugins@1.2.16...1.2.20 Changelog: https://github.com/lsp-plugins/lsp-plugins/releases/tag/1.2.20 (cherry picked from commit 6aacfc1)
And remove some unused inputs (cherry picked from commit 6f56a9c)
(cherry picked from commit aa112c8)
Diff: wwmm/easyeffects@v7.1.9...v7.2.3 Changelog: https://github.com/wwmm/easyeffects/blob/145a4a8cc329ec56bbef42d67450638f69dafb4a/CHANGELOG.md#723 (cherry picked from commit 273dcbd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
6.topic: agda
"A dependently typed programming language / interactive theorem prover"
6.topic: cinnamon
Desktop environment
6.topic: continuous integration
Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions
6.topic: deepin
Desktop environment and its components
6.topic: dotnet
Language: .NET
6.topic: emacs
Text editor
6.topic: Enlightenment DE
The Enlightenment Desktop Environment
6.topic: flakes
The experimental Nix feature
6.topic: GNOME
GNOME desktop environment and its underlying platform
6.topic: hardware
6.topic: haskell
6.topic: java
Including JDK, tooling, other languages, other VMs
6.topic: jitsi
6.topic: jupyter
Interactive computing tooling: kernels, notebook, jupyterlab
6.topic: k3s
Kubernates distribution (https://k3s.io/)
6.topic: lib
The Nixpkgs function library
6.topic: Lumina DE
The Lumina Desktop Environment
6.topic: mate
The MATE Desktop Environment
6.topic: module system
About "NixOS" module system internals
6.topic: nixos
Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS
6.topic: nixos-container
Imperative and declarative systemd-nspawn containers
6.topic: nvidia
Nvidia-specific issues and fixes
6.topic: pantheon
The Pantheon desktop environment
6.topic: php
6.topic: policy discussion
6.topic: printing
6.topic: python
6.topic: qt/kde
6.topic: rust
6.topic: systemd
6.topic: teams
Relating to team creation, updates, other management actions
6.topic: testing
Tooling for automated testing of packages and modules
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: vim
6.topic: xen-project
The Xen Project hypervisor
6.topic: xfce
The Xfce Desktop Environment
8.has: changelog
8.has: documentation
This PR adds or changes documentation
8.has: maintainer-list (update)
This PR changes `maintainers/maintainer-list.nix`
8.has: module (update)
This PR changes an existing module in `nixos/`
backport release-24.11
Backport PR automatically
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed broken link to the wireplumber doc page listing the locations of its config files
I'm not sure if any of these ⬇️ apply since it's such a simple fix. Sorry if I missed something in the contributing guidelines
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.