Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tail-tray #380047

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Add Tail-tray #380047

merged 2 commits into from
Feb 17, 2025

Conversation

Svenum
Copy link
Contributor

@Svenum Svenum commented Feb 7, 2025 •
edited
Loading

Add tail-tray: https://github.com/SneWs/tail-tray

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@K900
Copy link
Contributor

K900 commented Feb 7, 2025

Doesn't need to go into kdePackages, just put it in by-name.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Feb 7, 2025
@Svenum Svenum force-pushed the master branch 3 times, most recently from cc31db6 to aa942b7 Compare February 7, 2025 11:44
@github-actions github-actions bot added 10.rebuild-linux: 1 10.rebuild-linux: 1-10 and removed 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 7, 2025
@Svenum
Copy link
Contributor Author

Svenum commented Feb 7, 2025

Doesn't need to go into kdePackages, just put it in by-name.

Is moved 👍

@Svenum Svenum force-pushed the master branch 2 times, most recently from cc9cdb9 to 54a3a1b Compare February 7, 2025 13:07
@Svenum Svenum mentioned this pull request Feb 8, 2025
Open
SuperSandro2000
SuperSandro2000 requested changes Feb 16, 2025
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you squash all the package commits together to one init commit?

SuperSandro2000
SuperSandro2000 reviewed Feb 17, 2025
View reviewed changes
pkgs/by-name/ta/tail-tray/desktop.patch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should try upstreaming this as this is general wrong.

@SuperSandro2000 SuperSandro2000 merged commit 8a4b7b2 into NixOS:master Feb 17, 2025
30 checks passed
@Svenum Svenum added the backport release-24.11 Backport PR automatically label Feb 18, 2025
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Feb 18, 2025

Successfully created backport PR for release-24.11:

@nixpkgs-ci nixpkgs-ci bot mentioned this pull request Feb 18, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

@K900 K900 Awaiting requested review from K900

@NickCao NickCao Awaiting requested review from NickCao

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 backport release-24.11 Backport PR automatically
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Svenum @K900 @SuperSandro2000