Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libtiff: fix static (properly) #379305

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Feb 4, 2025

Fixing this was a very confusing time, and the wrong version of the patch ended up getting applied, which did not actually fix static. Swap it out for the accepted upstream patch.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@imincik imincik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks for working on it ! Looks good to me.

Fixing this was a very confusing time, and the wrong version of the
patch ended up getting applied, which did not actually fix static.
Swap it out for the accepted upstream patch.
@ofborg ofborg bot removed the ofborg-internal-error Ofborg encountered an error label Feb 4, 2025
@imincik imincik merged commit 59183db into NixOS:staging Feb 4, 2025
25 of 27 checks passed
@alyssais alyssais deleted the libtiff-static branch February 5, 2025 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants