python312Packages.tensorflow-bin: Allow supplying a custom source wheel #379202
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
#359605 introduced conditional logic in the
tensorflow-bin
package based on itssrc
andversion
. Unfortunately, its usage ofrec
prevents these properties from being overridden correctly withoverrideAttrs
(see #258246).Using a custom source wheel is quite useful when working with Jetsons, as NVIDIA's official builds are quite out of date: At the time of writing, only 2.16.1 for Python 3.10 is available, but a custom 2.18.0 wheel for Python 3.12 can be built manually.
This PR adds a
customSrc
parameter that can be used with.override
. For example:cc @GaetanLepage @mweinelt @SomeoneSerge
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.