Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.tensorflow-bin: Allow supplying a custom source wheel #379202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hacker1024
Copy link
Member

Things done

#359605 introduced conditional logic in the tensorflow-bin package based on its src and version. Unfortunately, its usage of rec prevents these properties from being overridden correctly with overrideAttrs (see #258246).

Using a custom source wheel is quite useful when working with Jetsons, as NVIDIA's official builds are quite out of date: At the time of writing, only 2.16.1 for Python 3.10 is available, but a custom 2.18.0 wheel for Python 3.12 can be built manually.

This PR adds a customSrc parameter that can be used with .override. For example:

cc @GaetanLepage @mweinelt @SomeoneSerge

tensorflow-bin.override {
  customSrc = {
    version = "2.18.0";
    src = builtins.storePath /nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-tensorflow-2.18.0-cp312-cp312-linux_aarch64.whl;
  };
}
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 3, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 15, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 23, 2025
@hacker1024 hacker1024 force-pushed the tensorflow-custom-src branch from 540eaa3 to 1f78da8 Compare February 23, 2025 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: python 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants