Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-conventional-commits: init at 2.6.7 #373930

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yzx9
Copy link
Contributor

@yzx9 yzx9 commented Jan 15, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@yzx9
Copy link
Contributor Author

yzx9 commented Jan 15, 2025

git-conventional-commits

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 373930


aarch64-darwin

✅ 1 package built:
  • git-conventional-commits

x86_64-linux

✅ 1 package built:
  • git-conventional-commits

@yzx9 yzx9 force-pushed the feature/nix-conventional-commits branch from 3e0dc34 to 604c876 Compare January 15, 2025 15:08
@yzx9 yzx9 requested a review from donovanglover January 15, 2025 15:09
Copy link
Member

@donovanglover donovanglover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything besides installPhase looks great. I haven't tested functionality but seems like the only difference after removing it is that the upstream CLI logic uses the file name instead of git-conventional-commits.

pkgs/by-name/gi/git-conventional-commits/package.nix Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants