Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-skyline: init at 0.1.3 #372227

Merged
merged 1 commit into from
Mar 11, 2025
Merged

gh-skyline: init at 0.1.3 #372227

merged 1 commit into from
Mar 11, 2025

Conversation

PerchunPak
Copy link
Member

@PerchunPak PerchunPak commented Jan 8, 2025 •
edited
Loading

https://github.com/github/gh-skyline: Generate a 3D model of your GitHub contribution history

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@PerchunPak PerchunPak marked this pull request as ready for review January 8, 2025 21:24
@PerchunPak
Copy link
Member Author

It actually works!

image

@Shawn8901
Copy link
Contributor

Fyi: we could use the new tag argument for the fetcher #355973

@PerchunPak
Copy link
Member Author

Oh, right, nix-init did this PR lol

@PerchunPak
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372227

x86_64-linux

✅ 1 package built:
  • gh-skyline

aarch64-linux

✅ 1 package built:
  • gh-skyline

x86_64-darwin

✅ 1 package built:
  • gh-skyline

aarch64-darwin

✅ 1 package built:
  • gh-skyline

@Shawn8901
Copy link
Contributor

build locally, and generated a stl file for my YTD contribution (default options) and ascii preview, looked at stl with some random web stl viewer.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 10, 2025
@PerchunPak
Copy link
Member Author

Will try to print my stl today

@PerchunPak
Copy link
Member Author

It works!

image psd
image

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5085

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2258

@eljamm
Copy link
Contributor

eljamm commented Feb 27, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372227

x86_64-linux

✅ 1 package built:
  • gh-skyline

aarch64-linux

✅ 1 package built:
  • gh-skyline

x86_64-darwin

✅ 1 package built:
  • gh-skyline

aarch64-darwin

✅ 1 package built:
  • gh-skyline

eljamm
eljamm approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@eljamm eljamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty neat. Thanks for packaging.

@eljamm eljamm added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Feb 27, 2025
@PerchunPak PerchunPak changed the title gh-skyline: init at 0.1.0 gh-skyline: init at 0.1.3 Feb 27, 2025
@PerchunPak
Copy link
Member Author

Updated to the latest version (this is a clean output of nix-update). Weird that this doesn't get merged even though it was reviewed and tested by multiple people.

https://github.com/github/gh-skyline/releases/tag/v0.1.3
https://github.com/github/gh-skyline/releases/tag/v0.1.2
https://github.com/github/gh-skyline/releases/tag/v0.1.1

@PerchunPak
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372227

x86_64-linux

✅ 1 package built:
  • gh-skyline

aarch64-linux

✅ 1 package built:
  • gh-skyline

x86_64-darwin

✅ 1 package built:
  • gh-skyline

aarch64-darwin

✅ 1 package built:
  • gh-skyline

@eljamm eljamm removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Feb 27, 2025
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 28, 2025
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Feb 28, 2025
@SuperSandro2000 SuperSandro2000 merged commit 81fd4c6 into NixOS:master Mar 11, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shawn8901 Shawn8901 Shawn8901 approved these changes

@eljamm eljamm eljamm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@PerchunPak @Shawn8901 @nixos-discourse @eljamm @SuperSandro2000 @wegank