Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hcp: init at 0.8.0 #370162

Merged
merged 2 commits into from
Jan 22, 2025
Merged

hcp: init at 0.8.0 #370162

merged 2 commits into from
Jan 22, 2025

Conversation

dbreyfogle
Copy link
Contributor

Adding HCP CLI, an official project from HashiCorp for interacting with HashiCorp Cloud Platform (HCP).

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 2, 2025
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jan 2, 2025
zimward
zimward approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@zimward zimward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good to me.

pkgs/by-name/hc/hcp/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 2, 2025
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 2, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 2, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370162

x86_64-linux

✅ 1 package built:
  • hcp

@lucasew
Copy link
Contributor

lucasew commented Jan 3, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370162

x86_64-linux

✅ 1 package built:
  • hcp

@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370162

aarch64-darwin

✅ 1 package built:
  • hcp

ethancedwards8
ethancedwards8 approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@ethancedwards8 ethancedwards8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ethancedwards8
ethancedwards8 suggested changes Jan 7, 2025
View reviewed changes
pkgs/by-name/hc/hcp/package.nix Outdated Show resolved Hide resolved
@wegank wegank added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 7, 2025
@lucasew
Copy link
Contributor

lucasew commented Jan 7, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370162

x86_64-linux

✅ 1 package built:
  • hcp

FliegendeWurst
FliegendeWurst reviewed Jan 18, 2025
View reviewed changes
pkgs/by-name/hc/hcp/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/hc/hcp/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/hc/hcp/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/hc/hcp/package.nix Outdated Show resolved Hide resolved
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 22, 2025
@FliegendeWurst FliegendeWurst merged commit 5544e59 into NixOS:master Jan 22, 2025
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasew lucasew lucasew left review comments

@zimward zimward zimward approved these changes

@ethancedwards8 ethancedwards8 ethancedwards8 approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dbreyfogle @lucasew @ethancedwards8 @FliegendeWurst @zimward @wegank @NixOSInfra