Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixel: 4.1.0 -> 5.1.1 + Add Update Script #369124

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

itzwam
Copy link
Contributor

@itzwam itzwam commented Dec 29, 2024

Things done

Enabled basic update script then ran it on my computer 👍

➜ nix-shell -I nixpkgs=$HOME/Documents/nixpkgs -p nixel --run 'nixel --version'
NixEL 5.1.1

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lucasew
Copy link
Contributor

lucasew commented Dec 29, 2024

Please split the commit into two

  • nixel: add update script
  • nixel: 4.1.0 -> 5.1.1

@itzwam
Copy link
Contributor Author

itzwam commented Dec 31, 2024

Please split the commit into two

* nixel: add update script

* nixel: 4.1.0 -> 5.1.1

done 👍
rebased + separated changes in 2 commits

pkgs/by-name/ni/nixel/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/ni/nixel/package.nix Outdated Show resolved Hide resolved
 + Fix rust crate::ffi bindgen error w/ clang 18&19  by downgrading to 16
@itzwam
Copy link
Contributor Author

itzwam commented Jan 20, 2025

Added some informations on why clang16,
Wasn't able to determine properly the exact bindgen version, because the similar issue seems to use unrelated versions

@itzwam itzwam requested review from lucasew and mattpolzin January 20, 2025 23:29
@mattpolzin
Copy link
Contributor

mattpolzin commented Jan 21, 2025

NOTE the following failure does not occur for the master branch build of nixel.

Result of nixpkgs-review pr 369124 run on x86_64-darwin 1

1 package failed to build:
  • nixel
  running: env -u IPHONEOS_DEPLOYMENT_TARGET "/nix/store/05lm9x40bab10mw9fpabkrqz9zmkwlbp-clang-wrapper-19.1.6/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-arch" "x86_64" "-I" "src" "-o" "/private/tmp/nix-build-nixel-5.1.1.drv-0/source/target/x86_64-apple-darwin/release/build/nixel-aa01d70438716331/out/src/utils.o" "-c" "src/utils.cc"
  cargo:warning=src/utils.cc:5:10: fatal error: 'cstring' file not found
  cargo:warning=    5 | #include <cstring>
  cargo:warning=      |          ^~~~~~~~~
  cargo:warning=1 error generated.
  exit status: 1

  --- stderr
  Failed to run rustfmt: No such file or directory (os error 2) (non-fatal, continuing)


  error occurred: Command env -u IPHONEOS_DEPLOYMENT_TARGET "/nix/store/05lm9x40bab10mw9fpabkrqz9zmkwlbp-clang-wrapper-19.1.6/bin/cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "-m64" "-arch" "x86_64" "-I" "src" "-o" "/private/tmp/nix-build-nixel-5.1.1.drv-0/source/target/x86_64-apple-darwin/release/build/nixel-aa01d70438716331/out/src/utils.o" "-c" "src/utils.cc" with args "cc" did not execute successfully (status code exit status: 1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants