ansible-compat: fix build by patching tests #368789
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paparodeo
reviewed
Dec 28, 2024
| # Patch incompatibility between tests and ansible-core | ||
| # TODO: remove when new release is out | ||
| (fetchpatch2 { | ||
| url = "https://github.com/ansible/ansible-compat/commit/39729217f41282884414c4b19f3c5156383fedc5.patch"; |
There was a problem hiding this comment.
I think with fetchatch2 you need to add ?full_index=1 to the end of the url. #266556 (comment) or this one #257446
There was a problem hiding this comment.
Ooops, thank you. Fixed.
ofalvai
force-pushed
the
ansible-compat-fix
branch
from
5298c07 to
b463914
Compare
|
@ofborg eval |
|
@ofborg build python3Packages.ansible-compat |
dawidd6
approved these changes
Dec 30, 2024
wegank
added
12.approvals: 1
|
Is this PR still relevant after #369664? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: ansible/ansible-compat#420
Hydra: https://hydra.nixos.org/build/283196918/log
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.