buildPython*: bring back buildPython*.override #366593
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
github-actions
bot
added
10.rebuild-darwin: 0
13 tasks
ShamrockLee
force-pushed
the
build-python-function-override
branch
from
e7aa58a to
c8b0f1d
Compare
|
Rebased the feature branch on top of |
Fix `makeOverridablePythonPackage` in python-package-base.nix
and unshadow `buildPython*.override`.
This makes it possible to override the dependencies of buildPython*.
E.g., `buildPythonPackage.override { unzip = unzip-custom; }`
returns a derived version of `buildPythonPackage` with
the `unzip` package overridden with `unzip-custom`.
ShamrockLee
force-pushed
the
build-python-function-override
branch
from
c8b0f1d to
442514d
Compare
|
Bump onto |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like packages, build helpers returned by
callPackagehave their ownoverridethat can produce a customized version of them with specific dependencies overridden. However, the current implementation ofmakeOverridablePythonPackage(the function that adds.overridePythonAttrsto the packagesbuildPython*returns) doesn't consider such<function>.overrideattribute, causingbuildPython*.overrideto get lost.This PR fixes
makeOverridablePythonPackageand unshadowsbuildPython*.override, making it possible to override the dependencies of buildPython*. E.g.,buildPythonPackage.override { unzip = unzip-custom; }returns a derived version ofbuildPythonPackagewith theunzippackage overridden withunzip-custom. Such overriding approaches can already be found in Nixpkgs. -- the implementation offetchFromGitHubusesfetchzip.override { withUnzip = false; }to obtain a custom version offetchzipwithoutunzip-related dependencies inside its returning derivation.This is a much simplified and less controversial version of #271762.
This PR causes no rebuild and is fully backward compatible.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.