Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

part-db: init at 1.14.5 #365249

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

felbinger
Copy link
Member

@felbinger felbinger commented Dec 14, 2024

closes #364907

content hash in patch/diff can be updated using: nix run nixpkgs#php84Packages.composer update --ignore-platform-req=ext-xsl symfony/stopwatch in the cloned repository

To be usable in a adequate way a nixos module is required. I will try to implement this too in this pr; until done this pr is just a draft.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@felbinger felbinger force-pushed the part-db-init branch 3 times, most recently from 67aebb9 to d905952 Compare December 14, 2024 21:44
@felbinger felbinger self-assigned this Dec 14, 2024
@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Dec 14, 2024
@felbinger felbinger force-pushed the part-db-init branch 2 times, most recently from 761347b to f256151 Compare December 14, 2024 21:58
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Dec 14, 2024
@felbinger felbinger force-pushed the part-db-init branch 2 times, most recently from d7d9b5e to c782595 Compare December 14, 2024 23:42
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes labels Dec 15, 2024
@felbinger felbinger force-pushed the part-db-init branch 2 times, most recently from 71ccb6a to b372373 Compare December 15, 2024 16:17
@h7x4 h7x4 added the 8.has: module (new) This PR adds a module in `nixos/` label Jan 17, 2025
@felbinger felbinger force-pushed the part-db-init branch 6 times, most recently from 0d8e4a4 to 7dd7260 Compare February 3, 2025 20:01
@felbinger felbinger marked this pull request as ready for review February 3, 2025 20:07
pkgs/by-name/pa/part-db/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/part-db/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/part-db/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/part-db/package.nix Outdated Show resolved Hide resolved
@felbinger
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 365249

Logs: https://github.com/felbinger/nixpkgs-review-gha/actions/runs/13122264044


x86_64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 1 package built:
  • part-db

aarch64-linux

⏩ 1 package blacklisted:
  • nixos-install-tools
✅ 1 package built:
  • part-db

x86_64-darwin


aarch64-darwin

pkgs/by-name/pa/part-db/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/part-db/package.nix Outdated Show resolved Hide resolved
@felbinger
Copy link
Member Author

felbinger commented Feb 4, 2025

1.15.2 is currently broken (results in http 500 error)

diff --git a/pkgs/by-name/pa/part-db/fix-composer-validate.diff b/pkgs/by-name/pa/part-db/fix-composer-validate.diff
index 73060f3e0591..3c4cd98e5cf5 100644
--- a/pkgs/by-name/pa/part-db/fix-composer-validate.diff
+++ b/pkgs/by-name/pa/part-db/fix-composer-validate.diff
@@ -2,23 +2,10 @@ diff --git a/composer.json b/composer.json
 index 0659f2ee..5a2dee70 100644
 --- a/composer.json
 +++ b/composer.json
-@@ -1,4 +1,6 @@
+@@ -1,5 +1,6 @@
  {
-+    "name": "part-db/part-db-server",
+     "name": "part-db/part-db-server",
 +    "description": "Part-DB is an Open source inventory management system for your electronic components",
      "type": "project",
      "license": "AGPL-3.0-or-later",
      "require": {
-diff --git a/composer.lock b/composer.lock
-index 614a35f7..e0c949eb 100644
---- a/composer.lock
-+++ b/composer.lock
-@@ -4,7 +4,7 @@
-         "Read more about it at https://getcomposer.org/doc/01-basic-usage.md#installing-dependencies",
-         "This file is @generated automatically"
-     ],
--    "content-hash": "465fa2ab7f9f8dad2b8cfbeaa640c136",
-+    "content-hash": "cec123f8cbf51820ba08c5c69ec2ded4",
-     "packages": [
-         {
-             "name": "amphp/amp",
diff --git a/pkgs/by-name/pa/part-db/package.nix b/pkgs/by-name/pa/part-db/package.nix
index 1d00c12f4228..5ec71626c0c5 100644
--- a/pkgs/by-name/pa/part-db/package.nix
+++ b/pkgs/by-name/pa/part-db/package.nix
@@ -14,7 +14,7 @@
 }:
 let
   pname = "part-db";
-  version = "1.14.5";
+  version = "1.15.2";
 
   srcWithVendor = php.buildComposerProject ({
     inherit pname version;
@@ -23,7 +23,7 @@ let
       owner = "Part-DB";
       repo = "Part-DB-server";
       tag = "v${version}";
-      hash = "sha256-KtNWog4aSnmgJsFckDuBrlnd9cj1f8kmSFi+nv2cZOg=";
+      hash = "sha256-KEzzl3CJQ8LvsmvsdBUSN6IepJ/Bapu6XZXhBvSs4hE=";
     };
 
     patches = [
@@ -40,7 +40,7 @@ let
       );
     };
 
-    vendorHash = "sha256-PJtm/3Vdm2zomUklVMKlDAe/vziJN4e+JNNf/u8N3B4=";
+    vendorHash = "sha256-zOyy7q3qqjJzJV5IVbvNcDmyqeLmTP9wjfbGlCi1lGU=";
 
     composerNoPlugins = false;
 
@@ -59,7 +59,7 @@ stdenv.mkDerivation (finalAttrs: {
 
   yarnOfflineCache = fetchYarnDeps {
     yarnLock = finalAttrs.src + "/yarn.lock";
-    hash = "sha256-Mjss2UUHVUdJ4UAI3GkG6HB6g7LbJTqvgrIXFhZmw1Q=";
+    hash = "sha256-j0jvDJROla0MLnZ2LGnaYWX3eE8MRuwDbtIl2PRq2oA=";
   };
 
   nativeBuildInputs = [

felbinger and others added 2 commits February 7, 2025 16:22
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Tert0 <[email protected]>
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Tert0 <[email protected]>
@felbinger
Copy link
Member Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 365249

Logs: https://github.com/felbinger/nixpkgs-review-gha/actions/runs/13202826090


x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • part-db

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 1 package built:
  • part-db

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (new) This PR adds a module in `nixos/` 8.has: module (update) This PR changes an existing module in `nixos/` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: part-db
3 participants