Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mago: init at 0.0.9 #363602

Merged
merged 1 commit into from
Dec 19, 2024
Merged

mago: init at 0.0.9 #363602

merged 1 commit into from
Dec 19, 2024

Conversation

gaelreyrol
Copy link
Contributor

This PR initialize mago :

A toolchain for PHP that aims to provide a set of tools to help developers write better code.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@gaelreyrol gaelreyrol self-assigned this Dec 9, 2024
@gaelreyrol gaelreyrol force-pushed the mago-init-0.0.5 branch 2 times, most recently from 1f6811a to 10be3df Compare December 9, 2024 16:02
getchoo
getchoo reviewed Dec 9, 2024
View reviewed changes
@getchoo
Copy link
Member

getchoo commented Dec 9, 2024

@ofborg build mago mago.passthru.tests

@gaelreyrol gaelreyrol requested a review from getchoo December 10, 2024 08:00
@gaelreyrol gaelreyrol changed the title mago: init at 0.0.5 mago: init at 0.0.6 Dec 10, 2024
getchoo
getchoo approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@getchoo getchoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to ping in a couple days if there are no other reviews

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1 10.rebuild-linux: 1 labels Dec 11, 2024
@gaelreyrol gaelreyrol changed the title mago: init at 0.0.6 mago: init at 0.0.7 Dec 11, 2024
@gaelreyrol gaelreyrol changed the title mago: init at 0.0.7 mago: init at 0.0.9 Dec 17, 2024
@getchoo getchoo added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 19, 2024
@getchoo getchoo merged commit 8d08b3a into NixOS:master Dec 19, 2024
47 of 48 checks passed
doronbehar pushed a commit to unclechu/nixpkgs that referenced this pull request Dec 22, 2024
@gaelreyrol @doronbehar
mago: init at 0.0.9 (NixOS#363602)
871f9c3
@gaelreyrol gaelreyrol deleted the mago-init-0.0.5 branch January 20, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@getchoo getchoo getchoo approved these changes

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees

@gaelreyrol gaelreyrol

Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaelreyrol @getchoo @Aleksanaa