Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python312Packages.setuptools: 75.1.0 -> 75.1.1 #354579

Merged
merged 1 commit into from
Nov 17, 2024
Merged

python312Packages.setuptools: 75.1.0 -> 75.1.1 #354579

merged 1 commit into from
Nov 17, 2024

Conversation

dotlambda
Copy link
Member

Diff: pypa/setuptools@refs/tags/v75.1.0...v75.1.1

Changelog: https://setuptools.pypa.io/en/stable/history.html#v75-1-1

fixes #353830
closes #354248

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@dotlambda dotlambda requested a review from mweinelt November 8, 2024 20:04
@dotlambda dotlambda added the 0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign label Nov 8, 2024
@mweinelt
Copy link
Member

mweinelt commented Nov 8, 2024

Wondering if this is a darwin stdenv rebuild 🫠 In which case it should probably go into the first staging-24.11 cycle.

@dotlambda
Copy link
Member Author

Wondering if this is a darwin stdenv rebuild

@ofborg will tell us, right?

@mweinelt
Copy link
Member

mweinelt commented Nov 8, 2024

Yep.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 8, 2024
@ofborg ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild label Nov 9, 2024
@ofborg ofborg bot requested review from mweinelt and natsukium November 9, 2024 03:00
@mweinelt mweinelt added this to the 24.11 milestone Nov 9, 2024
@mweinelt mweinelt marked this pull request as draft November 9, 2024 03:11
@dotlambda dotlambda changed the base branch from staging-next to staging November 9, 2024 16:40
@dotlambda dotlambda added the backport staging-24.11 Backport PR automatically label Nov 9, 2024
@dotlambda dotlambda marked this pull request as ready for review November 9, 2024 16:43
@wegank wegank added the 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package label Nov 10, 2024
@wegank wegank mentioned this pull request Nov 10, 2024
Merged
@mweinelt
Copy link
Member

We have setuptools 75.3.0 in #354627, so this should really only go into staging-24.11.

@dotlambda
Copy link
Member Author

Can't we just merge this and then rebase #354627?

@vcunat vcunat merged commit d495f20 into NixOS:staging Nov 17, 2024
44 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for staging-24.11:

@github-actions github-actions bot mentioned this pull request Nov 17, 2024
Merged
1 task
@dotlambda dotlambda deleted the python3Packages.setuptools branch November 17, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt Awaiting requested review from mweinelt

@natsukium natsukium Awaiting requested review from natsukium

Assignees
No one assigned
Labels
0.kind: ZHF Fixes Fixes during the Zero Hydra Failures (ZHF) campaign 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package backport staging-24.11 Backport PR automatically
Projects
None yet
Milestone
24.11
Development

Successfully merging this pull request may close these issues.
4 participants
@dotlambda @mweinelt @vcunat @wegank