php84: 8.4.0beta3 -> 8.4.0RC3 #353025
Merged
php84: 8.4.0beta3 -> 8.4.0RC3 #353025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nix-owners
bot
requested review from
aanderse,
drupol,
globin,
jtojnar,
Ma27 and
talyz
drupol
approved these changes
Nov 2, 2024
| + APXS_LIBEXECDIR="$prefix/modules" | ||
| if test -z `$APXS -q SYSCONFDIR`; then | ||
| if test -z $($APXS -q SYSCONFDIR); then |
There was a problem hiding this comment.
It is one of long standing patch we have, we have a similar version for PHP < 8.4 https://github.com/NixOS/nixpkgs/blob/397a2540e62c3a4a9b87a1a5e5d4424c79e110bc/pkgs/development/interpreters/php/fix-paths-php7.patch
I updated it to resolve some conflicts without thinking about it too much but it is likely something could be upstreamed so we do not have to carry it.
There was a problem hiding this comment.
Fair enough, all good for me
wegank
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
https://github.com/php/php-src/blob/php-8.4.0RC3/NEWS
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)nixpkgs-reviewresultGenerated using
nixpkgs-review.Command:
nixpkgs-reviewx86_64-linux⏩ 5 packages marked as broken and skipped:
❌ 30 packages failed to build:
✅ 141 packages built:
Add a 👍 reaction to pull requests you find important.