Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NixOS tests for various Prometheus exporters #352602

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Fix NixOS tests for various Prometheus exporters #352602

merged 3 commits into from
Nov 1, 2024

Conversation

wfdewith
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@wfdewith
prometheus-pgbouncer-exporter: 0.10.0 -> 0.10.2
bde2af7
@wfdewith
prometheus-surfboard-exporter: fix module vendoring
1b6b600 
Go 1.22 used the vendor directory without a valid modules.txt, but Go
1.23 this is no longer allowed.
@wfdewith
nixos/tests/prometheus-exporters/lnd: fix bitcoind configuration
44b3579 
bitcoind v28 made a breaking change that affects lnd. This setting
reverts bitcoind to old behavior until lnd is updated to be compatible
with bitcoind v28.
@github-actions github-actions bot added the 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS label Oct 31, 2024
SuperSandro2000
SuperSandro2000 approved these changes Oct 31, 2024
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 31, 2024
@ofborg ofborg bot requested review from disassembler and 1000101 October 31, 2024 17:34
@Ma27 Ma27 merged commit d9bd5a0 into NixOS:master Nov 1, 2024
32 of 33 checks passed
@wfdewith wfdewith deleted the prometheus-exporters branch November 2, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@disassembler disassembler Awaiting requested review from disassembler

@1000101 1000101 Awaiting requested review from 1000101

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wfdewith @Ma27 @SuperSandro2000 @wegank