Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

postgresql: fix passthru when using withPackages #351968

Closed
wants to merge 1 commit into from

Conversation

m1-s
Copy link
Contributor

@m1-s m1-s commented Oct 28, 2024

Currently, when using postgresqlWithPackages the passthru attributes are lost. This is causing errors in the postgresql nixos module as it needs the withJit passthru attributes.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nix-owners nix-owners bot requested a review from thoughtpolice October 28, 2024 19:57
@m1-s m1-s force-pushed the postgresPassthru branch from 8f69ad2 to 84d3b45 Compare October 28, 2024 20:03
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Oct 29, 2024
@wolfgangwalther
Copy link
Contributor

This will not work as expected, yet, because:

nix-repl> (pkgs.postgresql.withPackages (ps: []))
«derivation /nix/store/k5hyfpgsvra5ahi59nb82rk1y1mfqgas-postgresql-and-plugins-17.0.drv»

nix-repl> (pkgs.postgresql.withPackages (ps: [])).withJIT
«derivation /nix/store/qa9lkfa313gsnkhlks08cxqndx8ddrz2-postgresql-jit-17.0.drv»

i.e. once you use withJIT on your "postgresql-and-plugins", you'll end up with a bare postgresql_jit, without plugins.

wolfgangwalther added a commit to wolfgangwalther/nixpkgs that referenced this pull request Oct 29, 2024
This allows using postgresql.withPackages in the nixos module, which
calls withJIT and without JIT.

Supersedes NixOS#351968
@wolfgangwalther
Copy link
Contributor

I tried a slightly different approach in #352158, have a look!

@m1-s m1-s closed this Oct 30, 2024
tm-drtina pushed a commit to awakesecurity/nixpkgs that referenced this pull request Jan 29, 2025
This allows using postgresql.withPackages in the nixos module, which
calls withJIT and without JIT.

Supersedes NixOS#351968
tm-drtina pushed a commit to awakesecurity/nixpkgs that referenced this pull request Jan 29, 2025
This allows using postgresql.withPackages in the nixos module, which
calls withJIT and without JIT.

Supersedes NixOS#351968
tm-drtina pushed a commit to awakesecurity/nixpkgs that referenced this pull request Jan 30, 2025
This allows using postgresql.withPackages in the nixos module, which
calls withJIT and without JIT.

Supersedes NixOS#351968
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants