Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

less: 661 -> 668 #350108

Merged
merged 1 commit into from
Oct 24, 2024
Merged

less: 661 -> 668 #350108

merged 1 commit into from
Oct 24, 2024

Conversation

tomfitzhenry
Copy link
Contributor

@tomfitzhenry tomfitzhenry commented Oct 20, 2024

Things done

https://www.greenwoodsoftware.com/less/news.668.html

Also needed for some proposed refactorings in #347958.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@tomfitzhenry tomfitzhenry marked this pull request as draft October 20, 2024 22:37
@AndersonTorres
Copy link
Member

If it does not trigger the red tags of mass rebuild, then lgtm.

@tomfitzhenry
Copy link
Contributor Author

If it does not trigger the red tags of mass rebuild, then lgtm.

How does this look? Only the orange tag! (Surprising.)

@tomfitzhenry tomfitzhenry merged commit 9d27674 into NixOS:master Oct 24, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants