Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xournalpp: 1.2.3 -> 1.2.4 #350094

Merged
merged 2 commits into from
Oct 21, 2024
Merged

xournalpp: 1.2.3 -> 1.2.4 #350094

merged 2 commits into from
Oct 21, 2024

Conversation

ryand56
Copy link
Member

@ryand56 ryand56 commented Oct 20, 2024

https://github.com/xournalpp/xournalpp/releases/tag/v1.2.4

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sikmir
Copy link
Member

sikmir commented Oct 21, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 350094


x86_64-darwin

✅ 1 package built:
  • xournalpp

#163107 (comment)

@sikmir
Copy link
Member

sikmir commented Oct 21, 2024

Result of nixpkgs-review pr 350094 run on x86_64-linux 1

1 package built:
  • xournalpp

@sikmir sikmir merged commit 394fbda into NixOS:master Oct 21, 2024
33 of 34 checks passed
@ryand56 ryand56 deleted the update/xournalpp branch October 21, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants