[Backport release-24.05] wiki-js: 2.5.304 -> 2.5.305, reduce closure size by 50% #349703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ChangeLog: https://github.com/requarks/wiki/releases/tag/v2.5.305 (cherry picked from commit e0f63ad)
We effectively copy everything into `$out` (but this isn't using `buildCommand` to allow applying custom patches). However, this had the effect that `env-vars` was also copied into `$out` retaining a reference to the source tarball. Removing that reduces the closure size from 765.5M to 388.8M, i.e. by about 50.7%. (cherry picked from commit 3dc2d95)
13 tasks
ofborg
bot
added
10.rebuild-darwin: 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-24.05, triggered by a label in #349571.