nixos/nginx: create 127.0.0.1 alias for status page #349536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
ofborg
bot
added
10.rebuild-darwin: 0
| @@ -1226,6 +1226,7 @@ in | |||
| ++ lib.optional cfg.recommendedZstdSettings pkgs.nginxModules.zstd; | |||
|
|
|||
| services.nginx.virtualHosts.localhost = mkIf cfg.statusPage { | |||
| serverAliases = [ "127.0.0.1" ]; | |||
There was a problem hiding this comment.
Suggested change
| serverAliases = [ "127.0.0.1" ]; | |
| serverAliases = [ "127.0.0.1" "::1" ]; |
or is localhost resolving to that?
There was a problem hiding this comment.
I don't have IPv6 enabled so not sure but I've added an alias for it as well.
There was a problem hiding this comment.
I don't have IPv6 enabled
That's still a thing?
rhoriguchi
force-pushed
the
nixos/nginx
branch
from
a13cd06 to
d916854
Compare
Ma27
requested changes
Oct 23, 2024
wegank
added
the
12.approvals: 1
rhoriguchi
force-pushed
the
nixos/nginx
branch
from
d916854 to
449a963
Compare
Ma27
approved these changes
Oct 23, 2024
|
Will wait for ofborg and merge after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Makes the status page more intuitive, since you expect
127.0.0.1to work. Currentlycurl http://127.0.0.1/nginx_statuswill return a301.Also current description:
nixpkgs/nixos/modules/services/web-servers/nginx/default.nix
Lines 484 to 490 in a13cd06
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.