Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport staging-24.05] rsync: fix missing ipv6 support (again) #349349

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Bot-based backport to staging-24.05, triggered by a label in #322012.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

The patch was removed in 21604e8 despite not being included
in rsync v3.3.0, which broke IPv6 on at least darwin again.

(cherry picked from commit df5bf2f)
@osnyx
Copy link
Contributor

osnyx commented Oct 17, 2024

This fixes a regression: rsync-3.2.27 carried that patch already, but the patch has been removed again shortly before the 24.05 branch-off. Hence, the rsync in 24.05 only supports legacy IP.

The patch itself has already been merged in upstream rsync, but no release has been made since. RsyncProject/rsync#558

Copy link
Contributor

@ctheune ctheune left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@osnyx
Copy link
Contributor

osnyx commented Oct 17, 2024

@GrahamcOfBorg build rsync

@osnyx
Copy link
Contributor

osnyx commented Oct 18, 2024

I successfully built this on macOS 14.7. rsync now successfully transfers files via IPv6 and invoking it with the --ipv6 flag makes it call ssh -6.

@Ma27 Ma27 merged commit 999c581 into staging-24.05 Oct 18, 2024
24 of 26 checks passed
@Ma27 Ma27 deleted the backport-322012-to-staging-24.05 branch October 18, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants