-
-
Notifications
You must be signed in to change notification settings - Fork 15.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
percona: update packages, init 8.4 #346027
Conversation
I can also offer to run this through our extended test suite that combines percona-server and xtrabackup invocations, but that might take a few days. |
7720227
to
ace4425
Compare
I found a typo in a commit message and had to reword that commit. Code remains unchanged. |
ace4425
to
0115445
Compare
Our internal extended test suite currently fails for For |
I can happily report that our extended test suite passes again after enabling legacy password auth again. So the packages are working fine. |
0115445
to
ee7159a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes are looking good and the packages build for me.
Two things however:
- Should we also update the list of percona packages in
nixos/tests/mysql/common.nix
to match our current naming scheme? I'd suggest to just dopercona-server_8_0
andpercona-server_8_4
there (andpercona-server_8_5
when it gets out - or 9_0 or whatever the next one will be). - Also, I have one request about the commits themselves: I see that you've renamed files in the commits and then changed the imports in another commit (the rework naming part). This has the downside that there are some commits where percona doesn't evaluate which has the potential of making bisects unnecessarily hard. Can you please make sure that if you rename a file in a commit, the import of the file also gets changed already?
When reworking the percona package naming towards the two release streams "innovation" and "lts", I did not anticipate the case that two releases are long-term supported in parallel, and that the latest Innovation release is end-of-life and replaced by a more recent lts. Hence, the first-level attribute names now reflect the package major-minor versions again, augmented by attribute names pointing to respective lts and innovation releases.
ee7159a
to
19abdec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally this seems to be the right move. Also because Percona won't release Innovation releases anymore for 9.x
This is a new LTS release as well.
This is a new LTS release as well.
19abdec
to
16a8db0
Compare
@Ma27 You're correct with your remarks on rebasing. My motivation was to lay out the commits in a way that makes backporting easier, but I guess I found another good commit scoping now. |
Percona upstream has decided not to create releases or each MySQL innovation upstream release, but just for LTS releases. https://www.percona.com/blog/no-mysql-9-x-innovation-releases-from-percona/
Corrects the partially wrong change from NixOS#313931, all Oracle MySQL derivates are actually GPLv2 only.
0de43ab
to
f02bd5b
Compare
I fixed some small further nitpicks, also updated the designated backport. Please re-review. |
The forgot to change the passtru.test to the new package name, made a fix for that in #349757 |
percona-server_lts
andpercona-xtrabackup_lts
now point towards these packages-innovation
package names temporarily point to 8.4 as well, until the release of 8.5I had to restructure the package naming again, partially undoing #309953:
When reworking the percona package naming towards the two release
streams "innovation" and "lts", I did not anticipate the case that two
releases are long-term supported in parallel, and that the latest
Innovation release is end-of-life and replaced by a more recent lts.
Hence, the first-level attribute names now reflect the package
major-minor versions again, augmented by attribute names pointing to
respective lts and innovation releases.
notes on backporting
I intend to manually backport this to release-24.05. The package-updates will be kept as-is, but the
-lts
names will continue to point to the 8.0 release series to avoid breaking changes within a release.The backport is necessary, as 8.3 is end-of-life by now.
Changelogs:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.