-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nix-serve: unstable-2018-03-20 → unstable-2024-09-17 #342714
Conversation
@ofborg test nix-serve |
We should probably pin to 2.18 if it isn't merged in one or two days. Better not send a broken nix-serve to nixos-unstable |
pinning nix to 2.18 for this package also sounds like an acceptable solution, we could even create a PR and merge that meanwhile + rebase this to remove that pinning. |
…due to breaking changes" This reverts commit ae0a879.
6504445
to
f6f130b
Compare
@ofborg test nix-serve |
alternative approach: #342754 |
Upstream merged, leaving as draft due to alternative offered by @Mic92 though not closing for the time being. |
f6f130b
to
0a1ed49
Compare
0a1ed49
to
13f5638
Compare
This will be broken due to the nix 2.24 revert :s |
Indeed. I will pin nix 2.24. |
Follow up: #343274 |
Description of changes
Draft while upstream decides way forward
edolstra/nix-serve#60
Fixes broken nixosTests.nix-serve after
#335342
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.