Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alioth: init at 0.5.0 #339782

Merged
merged 1 commit into from
Oct 22, 2024
Merged

alioth: init at 0.5.0 #339782

merged 1 commit into from
Oct 22, 2024

Conversation

astro
Copy link
Contributor

@astro astro commented Sep 5, 2024 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Bot-wxt1221
Bot-wxt1221 suggested changes Sep 5, 2024
View reviewed changes
Copy link
Member

@Bot-wxt1221 Bot-wxt1221 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run nixfmt-rfc-style

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 5, 2024
@astro astro requested review from alyssais and Aleksanaa September 5, 2024 17:04
@astro astro requested a review from alyssais September 6, 2024 23:13
@astro astro force-pushed the alioth branch 2 times, most recently from 3604bd3 to 46a139c Compare October 20, 2024 20:50
alyssais
alyssais requested changes Oct 21, 2024
View reviewed changes
@astro astro requested a review from alyssais October 21, 2024 17:34
@alyssais
Copy link
Member

Needs rebased onto 8a70e31 to make CI happy.

@astro
Copy link
Contributor Author

astro commented Oct 21, 2024

Thanks, rebased!

@alyssais alyssais merged commit a60d8c9 into NixOS:master Oct 22, 2024
27 of 28 checks passed
@astro astro deleted the alioth branch October 22, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lencerf Lencerf Lencerf left review comments

@Bot-wxt1221 Bot-wxt1221 Bot-wxt1221 requested changes

@alyssais alyssais alyssais approved these changes

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@astro @alyssais @Lencerf @Aleksanaa @Bot-wxt1221