Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3.pkgs.apt: init at 2.8.0 #337048

Closed
wants to merge 2 commits into from
Closed

Conversation

mkg20001
Copy link
Member

Description of changes

add package

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@@ -719,6 +719,10 @@ self: super: with self; {

apsw = callPackage ../development/python-modules/apsw { };

apt = callPackage ../development/python-modules/apt {
apt = pkgs.apt;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make python-modules/apt take pkgs and use pkgs.apt in buildInputs ?

@alyssais
Copy link
Member

As I explained in the revert, this seems to be a duplicate of python3Packages.python-apt.

@mkg20001 mkg20001 closed this Aug 24, 2024
@mkg20001
Copy link
Member Author

🤦

@mkg20001 mkg20001 deleted the python-apt branch August 24, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants