-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python312Packages.numba: fix compatibility with numpy 2.0.1 #336281
Conversation
Looks good, but I wonder if it would be possible to make this compatible with numpy 2.1 although numba/numba#9708 ... I have a few questions from numba users: You use both numpy_2 and numpy_1 for the build... How does it work? I noticed that removing |
My alternative: #336284 |
Result of 22 packages marked as broken and skipped:
26 packages failed to build:
181 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged in the meantime until a numba with numpy 2.1 support will be released.
Ofborg's CI error with aarch64-linux is weird... How come it didn't fail for you @GaetanLepage locally?
|
Good question... maybe it has just been flaky on hydra... |
Description of changes
numba
got broken by the latest numpy update.While waiting for the next release, this patch should let it build.
Upstream issue: numba/numba#9687
Upstream PR: numba/numba#9683
cc @doronbehar
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.