Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wine64Packages.wayland: add missing wayland-scanner build input #336001

Merged

Conversation

trofi
Copy link
Contributor

@trofi trofi commented Aug 20, 2024

Without the change the build fails on staging as:

wine64-wayland> checking for wayland-scanner... Package wayland-scanner was not found in the pkg-config search path.
wine64-wayland> Perhaps you should add the directory containing `wayland-scanner.pc'
wine64-wayland> to the PKG_CONFIG_PATH environment variable
wine64-wayland> No package 'wayland-scanner' found
wine64-wayland> no
...
wine64-wayland> configure: error: Wayland 64-bit development files not found or not new enough, the Wayland driver won't be supported.
wine64-wayland> This is an error since --with-wayland was requested.

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Without the change the build fails on `staging` as:

    wine64-wayland> checking for wayland-scanner... Package wayland-scanner was not found in the pkg-config search path.
    wine64-wayland> Perhaps you should add the directory containing `wayland-scanner.pc'
    wine64-wayland> to the PKG_CONFIG_PATH environment variable
    wine64-wayland> No package 'wayland-scanner' found
    wine64-wayland> no
    ...
    wine64-wayland> configure: error: Wayland 64-bit development files not found or not new enough, the Wayland driver won't be supported.
    wine64-wayland> This is an error since --with-wayland was requested.
@trofi trofi mentioned this pull request Aug 20, 2024
13 tasks
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Aug 20, 2024
@alyssais
Copy link
Member

alyssais commented Aug 20, 2024

Not nativeBuildInputs?

@flokli
Copy link
Contributor

flokli commented Aug 20, 2024

Not nativeBuildInputs?

See the discussion in #214906 (comment). We can probably clean stuff up further in a followup.

@7c6f434c
Copy link
Member

Build failure looks unrelated to me.

@7c6f434c 7c6f434c merged commit b9d53f4 into NixOS:staging Aug 20, 2024
32 of 34 checks passed
@trofi trofi deleted the wine64Packages.wayland-add-wayland-scanner branch August 20, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants