Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recyclarr: build from source #334009

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

josephst
Copy link
Member

@josephst josephst commented Aug 11, 2024

Description of changes

This PR brings recyclarr to the latest version and switches from using a pre-built binary to building from source using buildDotnetModule. The package is also moved to by-name.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot requested a review from aldoborrero August 11, 2024 23:42
@josephst josephst marked this pull request as ready for review August 12, 2024 01:19
@josephst josephst force-pushed the feat/recyclarr-from-source branch from 009b655 to 18ebd72 Compare August 12, 2024 01:23
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/4393

@josephst josephst changed the title Recycler: build from source Recyclarr: build from source Aug 12, 2024
pkgs/by-name/re/recyclarr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/re/recyclarr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/re/recyclarr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/re/recyclarr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/re/recyclarr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/re/recyclarr/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/re/recyclarr/package.nix Show resolved Hide resolved
pkgs/by-name/re/recyclarr/package.nix Outdated Show resolved Hide resolved
@josephst josephst force-pushed the feat/recyclarr-from-source branch from 7871aac to aaba7b8 Compare August 12, 2024 03:18
@josephst
Copy link
Member Author

Just force-pushed a new version - using finalAttrs.version and confirmed the update script still works.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package labels Aug 14, 2024
@josephst josephst requested a review from eclairevoyant August 16, 2024 02:32
@SuperSandro2000 SuperSandro2000 merged commit 1201edc into NixOS:master Aug 22, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants