-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recyclarr: build from source #334009
Merged
SuperSandro2000
merged 4 commits into
NixOS:master
from
josephst:feat/recyclarr-from-source
Aug 22, 2024
Merged
Recyclarr: build from source #334009
SuperSandro2000
merged 4 commits into
NixOS:master
from
josephst:feat/recyclarr-from-source
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
Aug 11, 2024
recyclarr: add openssl as runtime dependency Addresses issue from NixOS#331498
josephst
force-pushed
the
feat/recyclarr-from-source
branch
from
August 12, 2024 01:23
009b655
to
18ebd72
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-ready-for-review/3032/4393 |
josephst
force-pushed
the
feat/recyclarr-from-source
branch
from
August 12, 2024 03:18
7871aac
to
aaba7b8
Compare
Just force-pushed a new version - using |
aldoborrero
approved these changes
Aug 14, 2024
wegank
added
12.approvals: 1
This PR was reviewed and approved by one reputable person
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
labels
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
10.rebuild-darwin: 1-10
10.rebuild-darwin: 1
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
12.approvals: 1
This PR was reviewed and approved by one reputable person
12.approved-by: package-maintainer
This PR was reviewed and approved by a maintainer listed in the package
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR brings
recyclarr
to the latest version and switches from using a pre-built binary to building from source usingbuildDotnetModule
. The package is also moved toby-name
.Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.