lldap-cli: init at 0-unstable-2024-02-24 #326131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
8.has: maintainer-list (update)
NixOSInfra
added
the
12. first-time contribution
eclairevoyant
suggested changes
Jul 10, 2024
| hash = "sha256-ZKRTYdgtOfV7TgpaVKLhYrCttYvB/bUexMshmmF8NyY="; | ||
| }; | ||
|
|
||
| buildInputs = [ bash coreutils gnugrep gnused jq curl ]; |
There was a problem hiding this comment.
Suggested change
| buildInputs = [ bash coreutils gnugrep gnused jq curl ]; |
these don't do anything as you're manually wrapping, and there's no hook here AFAICT that would use this attr
There was a problem hiding this comment.
Thanks a lot for your feedback. I'm new to this ecosystem and I'm very happy to improve my contributions over time.
This issue appeared, as I blindly followed the example for shell scripts in the wiki over here.
There was a problem hiding this comment.
For future reference, the wiki is often out-of-date, though this is a good first PR.
nwhirschfeld
changed the title
ofborg
bot
added
8.has: package (new)
eclairevoyant
approved these changes
Jul 10, 2024
vifino
approved these changes
Jul 10, 2024
vifino
added
the
12.approvals: 2
wegank
added
12.approvals: 1
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
https://github.com/Zepmann/lldap-cli
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.