-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py7zr: init at 0.21.1 #324293
base: master
Are you sure you want to change the base?
py7zr: init at 0.21.1 #324293
Conversation
FYI if you put |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I've provided some feedback below; I've avoided repeating the same feedback, but please consider these as applicable to all the packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please double check to run all available tests if feasible with pytestCheckHook?
|
||
format = "pyproject"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
format = "pyproject"; | |
pyproject = true; |
please replace all occurrences of this
|
||
|
||
build-system = [ | ||
setuptools | ||
setuptools-scm | ||
]; | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build-system = [ | |
setuptools | |
setuptools-scm | |
]; | |
build-system = [ | |
setuptools | |
setuptools-scm | |
]; | |
license = licenses.gpl2Plus; | ||
maintainers = with maintainers; [ ByteSudoer ]; | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}; | ||
|
||
|
||
build-system = [ | ||
setuptools | ||
setuptools-scm | ||
]; | ||
|
||
|
||
pythonImportsCheck = [ "bcj" "lzma" ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}; | |
build-system = [ | |
setuptools | |
setuptools-scm | |
]; | |
pythonImportsCheck = [ "bcj" "lzma" ]; | |
}; | |
build-system = [ | |
setuptools | |
setuptools-scm | |
]; | |
pythonImportsCheck = [ "bcj" "lzma" ]; |
, setuptools | ||
, setuptools-scm | ||
|
||
, pytest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is unused
pyproject = true; | ||
|
||
src = fetchPypi { | ||
inherit pname version; | ||
|
||
hash = "sha256-MniCe4A88Aah3yUfPhM3TH0m23eeWjMynMEXibgEvC0="; | ||
}; | ||
build-system = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pyproject = true; | |
src = fetchPypi { | |
inherit pname version; | |
hash = "sha256-MniCe4A88Aah3yUfPhM3TH0m23eeWjMynMEXibgEvC0="; | |
}; | |
build-system = [ | |
pyproject = true; | |
src = fetchPypi { | |
inherit pname version; | |
hash = "sha256-MniCe4A88Aah3yUfPhM3TH0m23eeWjMynMEXibgEvC0="; | |
}; | |
build-system = [ |
@ByteSudoer would you like me to finish this up for you? |
Description of changes
py7zr is a library and utility to support 7zip archive compression, decompression, encryption and decryption written by Python programming language.
Metadata
This PR also introduces these packages:
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.