-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
n8n: 1.9.3 -> 1.46.0, repackage with pnpm.fetchDeps #319310
Conversation
f2d6a9f
to
dbe4499
Compare
83868b6
to
f996fdf
Compare
f996fdf
to
13edaca
Compare
13edaca
to
32950b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works fine on x86_64-linux.
LGTM, thanks!
32950b6
to
a78f442
Compare
a78f442
to
a0b3e63
Compare
In the last few hours I updated this package from 1.45.1 to 1.46.0 and removed the pnpm version patch. Tested it on x86_64 and aarch64 linux, works as before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your work!
Since #290715 was merged, it's much easier to package and maintain pnpm projects.
Description of changes
node-env
,node-composition
stuff withpnpm.fetchDeps
andpnpm.configHook
oracledb
and@sap/hana-client
removal on aarch64: these don't exist in node_modules anymore and aarch64 build workspkgs.which
: probably was unused before, there were no references to itNIX_CFLAGS_COMPILE = "-DNODE_API_EXPERIMENTAL_NOGC_ENV_OPT_OUT";
: builds without this with node 20Issues I encountered and solved
Error: cannot find '/build/source/node_modules/.pnpm/[email protected]/node_modules/sqlite3/build/Release/node_sqlite3.node
pnpm.configHook
callspnpm install
with--ignore-scripts
that skips downloading/building node-sqlite3 bindings. A solution is building it manually: (usenode-gyp
from nixpkgs rather than from pnpm installed node_modules to avoid other errors)https://github.com/NixOS/nixpkgs/blob/077adff3243b078a0f4a49421038d6f3f16fdf37/pkgs/by-name/n8/n8n/package.nix#L65-L67
turbo run build: Failed to create APIClient: Unable to set up TLS. builder error: No such file or directory
In turbo release 1.12.4, they switched to using
rustls-tls-native-roots
rust crate which tries to open a file fromSSL_CERT_FILE
environment variable, which is set to/no-cert-file.crt
in a nix build environment. Addingcacert
to build inputs will set this env var to a real file, fixing the issue.ERR_PNPM_BAD_PM_VERSION This project is configured to use v9.1.4 of pnpm. Your current pnpm is v9.1.1.
Patching
package.json
to replace pnpm version to the current fixes it:https://github.com/NixOS/nixpkgs/blob/077adff3243b078a0f4a49421038d6f3f16fdf37/pkgs/by-name/n8/n8n/package.nix#L35
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.