-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pnpm: 9.1.1 -> 9.3.0 #319042
pnpm: 9.1.1 -> 9.3.0 #319042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM, maybe this is a good opportunity to run a nix build --rebuild
on all derivations that have a pnpmDeps
attribute?
Result of 1 package failed to build:
5 packages built:
|
The https://hydra.nixos.org/build/263034298 And the log there is missing, because https://gist.github.com/doronbehar/b165a5912be8bd06b9857a9b35eede8d I'm not sure why. Besides that, I ran:
And they all succeeded, hence this version bump looks totally good to me. |
I think it would be great if we had an easy way to test all FODs that rely on pnpm when updating. Maybe I can look into writing a test suite. |
@doronbehar Strange, I think I had a similar error when initially building the surrealist derivation. Will take a look at it later. I'm also working on updating to the latest version (#307031). Just a bit of rebasing and testing left. With that PR, the issue should be gone as the embed part is not required anymore since version 2.0. |
Description of changes
Bumping pnpm from 9.1.1 to 9.3.0
master...nathanscully:nixpkgs:pnpm-9.3.0
cc @Scrumplex @doronbehar
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)