-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pwalarmd: init at 0.1.0 #315703
Merged
Merged
pwalarmd: init at 0.1.0 #315703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will fix and repush |
Assuming OfBorg tests pass, PR is ready for consideration. |
heisfer
reviewed
May 30, 2024
heisfer
reviewed
May 30, 2024
heisfer
reviewed
May 30, 2024
heisfer
reviewed
May 30, 2024
Result of 1 package built:
|
Well, after reading more about https://github.com/NixOS/nixpkgs/tree/master/pkgs#meta-attributes I think Tested basic config provided by GitHub repo and worked just fine. |
This patch adds pwalarmd, a daemon which provides alarm clock services with custom notification support and live command-line configuration editing (achieved through pwalarmctl, which will be requested for addition separately). This patch does not add a service file, as pwalarmd is meant to be run in user mode. Home-Manager support will be added separately later for running pwalarmd under systemd/with declarative configuration. Signed-off-by: Amy Parker <[email protected]>
@heisfer added |
heisfer
approved these changes
May 30, 2024
Aleksanaa
approved these changes
May 31, 2024
wegank
pushed a commit
to amyipdev/nixpkgs
that referenced
this pull request
Jun 12, 2024
This patch adds pwalarmctl, a controller and status tool for the pwalarmd daemon that was merged in NixOS#315703. Signed-off-by: Amy Parker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
8.has: package (new)
This PR adds a new package
10.rebuild-darwin: 0
This PR does not cause any packages to rebuild on Darwin
10.rebuild-linux: 1-10
10.rebuild-linux: 1
11.by: package-maintainer
This PR was created by the maintainer of the package it changes
12.approvals: 1
This PR was reviewed and approved by one reputable person
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
This patch adds pwalarmd, a daemon which provides alarm clock services with custom notification support and live command-line configuration editing (achieved through pwalarmctl, which will be requested for addition separately).
This patch does not add a service file, as pwalarmd is meant to be run in user mode. Home-Manager support will be added separately later for running pwalarmd under systemd/with declarative configuration.
Homepage: https://github.com/amyipdev/pwalarmd
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage N/A./result/bin/
)Add a 👍 reaction to pull requests you find important.