Disallow output changes in installCheckPhase
#303361
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will indicate errors in the install script fixed up by the installed software, or software or configuration that relies on a writable installation directory.
roberth
changed the title
installCheckPhase
12 tasks
roberth
added
0.kind: enhancement
Ericson2314
reviewed
Apr 11, 2024
pkgs/test/default.nix
Outdated
Comment on lines
91
to
109
| # NB: ^^^^^^ | ||
| # `import` and not `callPackage`, because we manipulate the whole `pkgs` | ||
| # so that we can unit test without rebuilding everything; see setup/default.nix. | ||
| basePkgs = | ||
| if ! pkgs.config?baseCommit then pkgs | ||
| else import ../.. { | ||
| inherit (pkgs.stdenv.hostPlatform) system; | ||
| config = { | ||
| setupScript = "${ | ||
| let oldPkgsStr = builtins.fetchGit { url = ../..; ref = pkgs.config.baseCommit; }; | ||
| oldPkgsPath = /. + builtins.unsafeDiscardStringContext (oldPkgsStr); | ||
| in oldPkgsPath + "/pkgs/stdenv/generic/setup.sh" | ||
| }"; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
I imagine other tests might start using this at some point :)
Ericson2314
approved these changes
Apr 11, 2024
wegank
added
the
12.approvals: 1
4 tasks
infinisil
reviewed
May 25, 2024
Since the previous commit is already a mass-rebuild, I've taken the opportunity to add important documentation to setup.sh.
infinisil
force-pushed
the
disallow-output-changes-in-installCheck
branch
from
4829c07 to
07e3b36
Compare
github-actions
bot
removed
the
6.topic: testing
wegank
removed
the
12.approvals: 1
wegank
added
the
2.status: merge conflict
wegank
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
tests.setupwhich runs quicker thantests.stdenv. cc @ArtturinThis will indicate errors in the install script fixed up by the installed software, or software or configuration that relies on a writable installation directory.
NOTE: this only works for derivations which use the installCheck phase as intended. Some language integrations, like
pythonPackages, need to call the new functions on their own.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.