Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attic-client: remove env attribute #299288

Merged
merged 1 commit into from
Mar 26, 2024
Merged

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Mar 26, 2024

Related to #292043

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol
Copy link
Contributor Author

drupol commented Mar 26, 2024

@ofborg eval

Copy link
Member

@anthonyroussel anthonyroussel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build does pass on aarch64-darwin ✔️

Thanks for your help :)

@anthonyroussel anthonyroussel added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Mar 26, 2024
@K900 K900 merged commit 81d35de into NixOS:master Mar 26, 2024
6 of 7 checks passed
@drupol drupol deleted the attic/fix-libcxx-stuff branch March 26, 2024 19:51
@stepbrobd stepbrobd mentioned this pull request Mar 26, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants