-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discover-overlay: init at 0.7.0 #295938
Discover-overlay: init at 0.7.0 #295938
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Some feedback below, and also please ensure to rebase to have the maintainers
commit come first.
@eclairevoyant I've made those changes. How can I rebase to have that commit come first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got a chance to build/run this now. With the changes below, it does build and run, and even connects to discord, though I don't see an actual overlay.
Is there a way you're testing this?
b6e04da
to
a96b386
Compare
when I run the app, I jump into an empty discord call in a server. if it works, an icon with your avatar appears and will light up green as you talk. The other way to test is to run discover-overlay -c which opens the configuration menu |
Thanks. The configuration menu works, but can't get the overlay to show up. Possibly a config issue on my side, but at least the program runs. Can you squash the later commits into the 2nd one? (i.e. there should be only two commits, the maintainer commit and the init one.) Seems fine otherwise. |
abc309b
to
680b954
Compare
@eclairevoyant Done! Thanks for the help |
Oh, after seeing the darwin failure - I guess this is only meant for Linux, can we set |
680b954
to
21c9e66
Compare
Description of changes
Yet another Discord overlay for Linux written in Python using GTK3.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.