Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discover-overlay: init at 0.7.0 #295938

Merged
merged 2 commits into from
Apr 13, 2024

Conversation

dragonginger10
Copy link
Contributor

@dragonginger10 dragonginger10 commented Mar 14, 2024

Description of changes

Yet another Discord overlay for Linux written in Python using GTK3.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Mar 14, 2024
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 14, 2024
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Some feedback below, and also please ensure to rebase to have the maintainers commit come first.

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
pkgs/by-name/di/discover-overlay/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/di/discover-overlay/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/di/discover-overlay/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/di/discover-overlay/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/di/discover-overlay/package.nix Show resolved Hide resolved
@dragonginger10
Copy link
Contributor Author

@eclairevoyant I've made those changes. How can I rebase to have that commit come first?

Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got a chance to build/run this now. With the changes below, it does build and run, and even connects to discord, though I don't see an actual overlay.

Is there a way you're testing this?

pkgs/by-name/di/discover-overlay/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/di/discover-overlay/package.nix Show resolved Hide resolved
pkgs/by-name/di/discover-overlay/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/di/discover-overlay/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/di/discover-overlay/package.nix Outdated Show resolved Hide resolved
@dragonginger10 dragonginger10 force-pushed the discover-overlay-0.7.0 branch from b6e04da to a96b386 Compare April 11, 2024 22:39
@dragonginger10
Copy link
Contributor Author

Got a chance to build/run this now. With the changes below, it does build and run, and even connects to discord, though I don't see an actual overlay.

Is there a way you're testing this?

when I run the app, I jump into an empty discord call in a server. if it works, an icon with your avatar appears and will light up green as you talk. The other way to test is to run discover-overlay -c which opens the configuration menu

@eclairevoyant eclairevoyant dismissed their stale review April 12, 2024 02:34

stale review

@eclairevoyant
Copy link
Contributor

eclairevoyant commented Apr 12, 2024

Thanks. The configuration menu works, but can't get the overlay to show up. Possibly a config issue on my side, but at least the program runs.

Can you squash the later commits into the 2nd one? (i.e. there should be only two commits, the maintainer commit and the init one.) Seems fine otherwise.

@dragonginger10 dragonginger10 force-pushed the discover-overlay-0.7.0 branch from abc309b to 680b954 Compare April 12, 2024 22:27
@dragonginger10
Copy link
Contributor Author

@eclairevoyant Done! Thanks for the help

@eclairevoyant
Copy link
Contributor

Oh, after seeing the darwin failure - I guess this is only meant for Linux, can we set meta.platforms to lib.platforms.linux? I can merge directly after.

@dragonginger10 dragonginger10 force-pushed the discover-overlay-0.7.0 branch from 680b954 to 21c9e66 Compare April 13, 2024 15:07
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1 10.rebuild-darwin: 1-10 labels Apr 13, 2024
@eclairevoyant eclairevoyant merged commit a083aec into NixOS:master Apr 13, 2024
26 checks passed
@dragonginger10 dragonginger10 deleted the discover-overlay-0.7.0 branch April 14, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants