tlclient: init at 4.16.0 #293173
Closed
tlclient: init at 4.16.0 #293173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NixOSInfra
added
the
12. first-time contribution
ofborg
bot
added
10.rebuild-darwin: 0
|
I run the client and I have encountered 0 issue, all the functionalities were there. |
wegank
added
the
2.status: merge conflict
|
😥 does this merged soon? |
eclairevoyant
suggested changes
Aug 7, 2024
There was a problem hiding this comment.
Please run nixfmt on this file.
Also, this should go in pkgs/by-name...
| @@ -5433,6 +5433,8 @@ with pkgs; | |||
|
|
|||
| fx = callPackage ../development/tools/fx { }; | |||
|
|
|||
| tlclient = callPackage ../applications/networking/remote/tlclient { }; | |||
There was a problem hiding this comment.
...and remove this entry.
| }) | ||
| ]; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
Suggested change
| meta = with lib; { | |
| meta = { |
tracking issue: #292468
Comment on lines
+69
to
+70
| maintainers = with maintainers; [ shamilton ]; | ||
| platforms = platforms.linux; |
There was a problem hiding this comment.
Suggested change
| maintainers = with maintainers; [ shamilton ]; | |
| platforms = platforms.linux; | |
| maintainers = with lib.maintainers; [ shamilton ]; | |
| platforms = [ "x86_64-linux" ]; |
There was a problem hiding this comment.
also did you check with @SCOTT-HAMILTON if they are still prepared to maintain this?
|
|
||
| nativeBuildInputs = [ autoPatchelfHook copyDesktopItems ]; | ||
| propagatedBuildInputs = [ alsa-lib libX11 pcsclite ]; | ||
|
|
There was a problem hiding this comment.
Suggested change
| dontConfigure = true; |
| }; | ||
|
|
||
| nativeBuildInputs = [ autoPatchelfHook copyDesktopItems ]; | ||
| propagatedBuildInputs = [ alsa-lib libX11 pcsclite ]; |
There was a problem hiding this comment.
why are these propagated?
| src = fetchurl { | ||
| # x86_64 arch tarball | ||
| url = "https://www.cendio.com/downloads/clients/tl-${version}-client-linux-dynamic-x86_64.tar.gz"; | ||
| sha256 = "ea3a92186cbaf71cc4ab692b3baeadd94b3836242e58705a38fe3683f4f18691"; |
There was a problem hiding this comment.
please use SRI hash (set hash = ""; and then get the hash from the error)
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #106052 (no idea why that never got merged), fixes #105399
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.