Fix x11 include and lib parameters for configure script. #2923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| configureFlags = ["-no-tk"] ++ optionals useX11 [ "-x11lib" x11 ]; | ||
| configureFlags = ["-no-tk"] ++ optionals useX11 [ "-x11lib" x11lib | ||
| "-x11include" x11inc ]; | ||
|
|
There was a problem hiding this comment.
Won't it work if you simply add correct buildInputs?
There was a problem hiding this comment.
No, because the configure script checks for the existence of certain X11 headers and libs, first in the user-supplied directories, then in the standard locations if the user does not specify them. If these headers and libs are not found the configure script disables support for the graphics library.
|
Maybe useX11 could be made parameter expression? Different defaults on large and small platforms, but changeable from outside. |
|
That makes sense to me, maybe x11 support should be enabled based on services.xserver.enable ? |
Closed
|
This can only be a default |
|
Incoming SSH, Xvnc… |
Merged
|
see also #3330 |
|
Seems to make sense and still builds. |
This was referenced Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #2922