Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerd: 1.7.12 -> 1.7.13 #285438

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Conversation

r-ryantm
Copy link
Contributor

@r-ryantm r-ryantm commented Feb 1, 2024

Automatic update generated by nixpkgs-update tools. This update was made based on information from https://repology.org/project/containerd/versions.

meta.description for containerd is: A daemon to control runC

meta.homepage for containerd is: https://containerd.io/

meta.changelog for containerd is: https://github.com/containerd/containerd/releases/tag/v1.7.13

Updates performed
  • Golang update
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • Warning: a test defined in passthru.tests did not pass
  • found 1.7.13 with grep in /nix/store/5d69vzq6w65bsq5iwb9swqknl3qa08hw-containerd-1.7.13
  • found 1.7.13 in filename of file in /nix/store/5d69vzq6w65bsq5iwb9swqknl3qa08hw-containerd-1.7.13

Rebuild report (if merged into master) (click to expand)
19 total rebuild path(s)

19 package rebuild(s)

First fifty rebuilds by attrpath
airlift
apptainer
apptainer-overriden-nixos
charliecloud
containerd
docker
docker-gc
docker-sbom
docker_20_10
docker_24
flintlock
fn-cli
nvidia-docker
pipework
python311Packages.jupyter-repo2docker
python312Packages.jupyter-repo2docker
singularity
singularity-overriden-nixos
udocker
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/5d69vzq6w65bsq5iwb9swqknl3qa08hw-containerd-1.7.13 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A containerd https://github.com/r-ryantm/nixpkgs/archive/d714be41ca1a0b321d447a582bef9d1d71104109.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/d714be41ca1a0b321d447a582bef9d1d71104109#containerd

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/5d69vzq6w65bsq5iwb9swqknl3qa08hw-containerd-1.7.13
ls -la /nix/store/5d69vzq6w65bsq5iwb9swqknl3qa08hw-containerd-1.7.13/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

Result of nixpkgs-review run on x86_64-linux 1

2 packages marked as broken and skipped:
  • python312Packages.jupyter-repo2docker
  • python312Packages.jupyter-repo2docker.dist
21 packages built:
  • airlift
  • airlift.dist
  • apptainer
  • apptainer-overriden-nixos
  • charliecloud
  • containerd
  • docker
  • docker-gc
  • docker-sbom
  • docker_20_10
  • docker_20_10.man
  • flintlock
  • fn-cli
  • nvidia-docker
  • pipework
  • python311Packages.jupyter-repo2docker
  • python311Packages.jupyter-repo2docker.dist
  • singularity
  • singularity-overriden-nixos
  • udocker
  • udocker.dist

Maintainer pings

cc @offlinehacker @vdemeester @endocrimes for testing.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Feb 1, 2024
@999eagle 999eagle added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Feb 1, 2024
@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 1, 2024
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Feb 1, 2024
@NickCao
Copy link
Member

NickCao commented Feb 1, 2024

@ofborg test docker

@NickCao
Copy link
Member

NickCao commented Feb 1, 2024

@ofborg test kubernetes

@NickCao
Copy link
Member

NickCao commented Feb 1, 2024

I see a lot of errors in kubernetes nixos tests. Unsure if related to this PR.

@leona-ya
Copy link
Member

leona-ya commented Feb 1, 2024

I see a lot of errors in kubernetes nixos tests. Unsure if related to this PR.

The kubernetes tests seem also to be broken on master to me, but I'm not a kubernetes expert.

@NickCao
Copy link
Member

NickCao commented Feb 1, 2024

ping kubernetes maintaines: @johanot @saschagrunert @srhb

@srhb
Copy link
Contributor

srhb commented Feb 1, 2024

These look like the certmgr 2 issues I dropped the ball on and not related to containerd.

@NickCao NickCao merged commit d1f044c into NixOS:master Feb 1, 2024
32 of 36 checks passed
@r-ryantm r-ryantm deleted the auto-update/containerd branch February 2, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants