paper-plane: init at 0.1.0-beta.5

[Aleksanaa]

Description of changes

Darwin should be supported but not tested yet.

Closes #281095

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Guanran928]

Won't build on x86_64-darwin

Full log: https://fars.ee/sJaE

❯ nix build github:Aleksanaa/nixpkgs/paper-plane#paper-plane
       last 10 log lines:
       >
       > upgrade: 'bind-property' is no longer needed. Use 'bind' instead. (blueprint 0.8.2)
       > at ../src/ui/session/sidebar/chat_folder/bar.blp line 41 column 29:
       >   41 |        selected-chat-list: bind-property template.selected-chat-list bidirectional;
       >      |                            ^
       >
       > [33/34] Generating src/ui/ui-resources_gresource with a custom command
       > FAILED: src/paper-plane
       > /nix/store/dsvdw81x1nzb0c2lr5shywmwffl8dw1s-coreutils-9.4/bin/env CARGO_HOME=/private/tmp/nix-build-paper-plane-0.1.0-beta.5.drv-0/source/build/cargo-home /nix/store/idh95h6k2zp83h1v556jq9n47ak4pf2j-cargo-1.74.0/bin/cargo build --manifest-path /private/tmp/nix-build-paper-plane-0.1.0-beta.5.drv-0/source/Cargo.toml --target-dir /private/tmp/nix-build-paper-plane-0.1.0-beta.5.drv-0/source/build/src --release && cp src/release/paper-plane src/paper-plane
       > ninja: build stopped: subcommand failed.
       For full logs, run 'nix log /nix/store/9cm8lfczbhr15nxsyiwwwg34g849w7i2-paper-plane-0.1.0-beta.5.drv'.

[Aleksanaa]

  /private/tmp/nix-build-paper-plane-0.1.0-beta.5.drv-0/tfacd-0/gettext/libtextstyle/lib/obstack.c:351:31: error: incompatible function pointer types initializing 'void (*)(void) __attribute__((noreturn))' with an expression of type 'void (void)' [-Wincompatible-function-pointer-types]
  __attribute_noreturn__ void (*obstack_alloc_failed_handler) (void)
                                ^
  1 error generated.
  make[5]: *** [Makefile:2448: obstack.lo] Error 1
  make[5]: *** Waiting for unfinished jobs....
  make[4]: *** [Makefile:2157: all] Error 2
  make[3]: *** [Makefile:1786: all-recursive] Error 1
  make[2]: *** [Makefile:1714: all] Error 2
  make[1]: *** [Makefile:403: all-recursive] Error 1
  make: *** [Makefile:359: all] Error 2
  thread 'main' panicked at /private/tmp/nix-build-paper-plane-0.1.0-beta.5.drv-0/cargo-vendor-dir/gettext-sys-0.21.3/build.rs:300:5:

  command did not execute successfully, got: exit status: 2

  build script failed, must exit now

It seems to be gettext-sys, but I'm not sure why

[Aleksanaa]

gettext-rs/gettext-rs#114

[Aleksanaa]

@Guanran928 Please test again if you have time, thanks!

[ocfox]

Result of nixpkgs-review pr 284804 run on aarch64-darwin 1

1 package failed to build:

• paper-plane

Full logs

https://pastb.in/eakoisiver.sh
https://logs.ofborg.org/?key=nixos/nixpkgs.284804&attempt_id=0ca4099d-fc58-448f-91fb-1a4623f851b9

[ocfox]

Possibly forgot darwin.apple_sdk.frameworks.

[Aleksanaa]

Possibly forgot darwin.apple_sdk.frameworks.

I know for sure, but what's next?

[Guanran928]

Sorry, my Internet was down :-(

b03037787168b670e8f8f265725773700f3073c3 builds, but launching it never worked.

[Aleksanaa]

Should fix it. Linux doesn't seem to select the same gtk4 library from two directories at the same time (one is the patched gtk4, the other is the original, probably introduced due to libadwaita), so no problem occurs.

[Guanran928]

Still not launching :(

[Aleksanaa]

Now there shouldn't be two gtk4, but I'm not sure if that's really the case.

[Guanran928]

It launches now!

However the icon in the login page isn't showing properly...

[Aleksanaa]

However the icon in the login page isn't showing properly...

Does this also happen for other gtk4 apps?

[Guanran928]

However the icon in the login page isn't showing properly...

Does this also happen for other gtk4 apps?

I'm not sure... I don't use macOS often and before this PR I didn't even knew GTK works on macOS...

[Aleksanaa]

I'm not sure if I should include an icon theme in the package closure, as this may not be desired. See related discussion here: #43150 (comment)
Also libadwaita doesn't pick up a default icon theme. That's strange.

[Aleksanaa]

You can try adwaita-1-demo in libadwaita.devdoc.

[Guanran928]

[Aleksanaa]

Then that's out of scope for this pr. An icon theme should be installed to make it display normally.

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1431

[Aleksanaa]

@wegank able to merge?

[kirillrdy]

@Aleksanaa thank you !

if it breaks, feel free to tag me, then we can have a look at possible ways of fixing it !