protobuf-c: unstable-2023-07-08 -> 1.5.0 #283783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haraldh
force-pushed
the
update_protobufc
branch
from
a0e43e9 to
2bb53a1
Compare
matthiasbeyer
approved these changes
Jan 25, 2024
delroth
added
the
12.approvals: 1
This comment was marked as outdated.
This comment was marked as outdated.
haraldh
force-pushed
the
update_protobufc
branch
2 times, most recently
from
b0905c0 to
aa41cd1
Compare
delroth
removed
the
12.approvals: 1
This comment was marked as duplicate.
This comment was marked as duplicate.
haraldh
force-pushed
the
update_protobufc
branch
from
aa41cd1 to
56bd494
Compare
|
Split out Rerouted the unbound configure path for protobufc to the Fixed anbox package moving protobufc to |
This comment was marked as duplicate.
This comment was marked as duplicate.
|
anbox still fails to build.. but due to C++ issues |
|
I don't feel like implementing the workaround in |
|
@NickCao that would imply patching the autofoo of the original unbound source |
I know nobody want to touch that, but yes. |
This whole mess can be replaced with a call to |
|
@NickCao How about a TODO note in the unbound/default.nix, stating the removal of this workaround... I really don't want to do it. |
I mean we don't need the workaround if not doing the output split in this PR, I might try to fix this later. |
The fix is now merged as NLnetLabs/unbound#999 |
13 tasks
13 tasks
wegank
added
the
2.status: merge conflict
|
Please rebase |
ofborg
bot
added
10.rebuild-linux: 501+
10.rebuild-linux: 501-1000
and removed
2.status: merge conflict
|
@SuperSandro2000 done |
|
third run: Result of 24 packages marked as broken and skipped:
2 packages blacklisted:
79 packages failed to build:
1031 packages built:
|
Release notes: https://github.com/protobuf-c/protobuf-c/releases/tag/v1.5.0 Split out `dev` and `lib`. Fixed anbox package moving protobufc to `nativeBuildInputs`, because the `proto-c` tool is used at `build-time`. Signed-off-by: Harald Hoyer <[email protected]>
SuperSandro2000
force-pushed
the
update_protobufc
branch
from
7177f61 to
b281d60
Compare
|
There are only some MSVC cmake fixes protobuf-c/protobuf-c@fa86fdd...v1.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
protobuf-c: unstable-2023-07-08 -> 1.5.0
Release notes: https://github.com/protobuf-c/protobuf-c/releases/tag/v1.5.0
Split out
devandlib.Fixed anbox package moving protobufc to
nativeBuildInputs, becausethe
proto-ctool is used atbuild-time.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.