cudaPackages.cuda_nvcc: don't inspect the cc wrapper #282382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unbreaks evaluation after the refactoring in 86c28ee (NixOS#282220). Explicitly extending nvcc's LIBRARIES may have been redundant (building something mildly cursed like jaxlib may be necessary to verify) Previously: ``` ❯ NIXPKGS_ALLOW_UNFREE=1 nix-instantiate '.' -A tests.cuda ... error: necessary to fix CI ❯ nix build -f '.' --arg config '{ allowUnfree = true; }' -L python3Packages.torchWithCuda ... error: necessary to fix CI ``` Now: ``` ❯ NIXPKGS_ALLOW_UNFREE=1 nix-instantiate '.' -A tests.cuda /nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-cuda-samples-12.2.drv /nix/store/eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee-saxpy-unstable-2023-07-11.drv ... ```
SomeoneSerge
force-pushed
the
fix/tests-cuda-eval
branch
from
8dac121 to
fb6b846
Compare
ofborg
bot
added
8.has: package (new)
SomeoneSerge
changed the title
samuela
approved these changes
Jan 21, 2024
There was a problem hiding this comment.
Thanks @SomeoneSerge ! I just got hit with a bunch of these error: necessary to fix CI errors in https://github.com/samuela/nixpkgs-upkeep/actions/runs/7597660003
delroth
added
the
12.approvals: 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the evaluation after the refactoring in 86c28ee (#282220).
The way I explicitly extended
nvcc.profile's LIBRARIES may have been redundant (building something mildly cursed like jaxlib may be necessary to verify). We should also strive to avoid looking inside the wrapper (e.g. theuseLibsFrominterface should be mostly sufficient for our purposes). Basic things likesaxpydo work.Previously:
Now:
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)CC @NixOS/cuda-maintainers
Add a 👍 reaction to pull requests you find important.