Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds glibcLocales to pycharm-community #281238

Conversation

PedroRegisPOAR
Copy link
Contributor

@PedroRegisPOAR PedroRegisPOAR commented Jan 15, 2024

Description of changes

In non-NixOS systems, if the used keyboard has some non ASCII characters (like á ã ç é ö) those would not show up after typed.
Found that too that if some file name has non ASCII characters the pycharm will not show the file.
This PR is supposed to fix this.

How to test?

nix run --refresh github:PedroRegisPOAR/nixpkgs/adds-glibcLocales-to-pycharm-community#jetbrains.pycharm-community

It is not need, but for the sake of completeness, if you want to install it:

nix profile install --refresh github:PedroRegisPOAR/nixpkgs/adds-glibcLocales-to-pycharm-community#jetbrains.pycharm-community

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100 labels Jan 16, 2024
@brenomfviana
Copy link

I've installed PyCharm via Nix in Ubuntu 22.04.3 LTS, and I was suffering with the lack of non ASCII characters.

The @PedroRegisPOAR's solution worked nicely for me.

@github-actions github-actions bot removed 8.has: documentation This PR adds or changes documentation 8.has: changelog 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: emacs Text editor 6.topic: rust 6.topic: policy discussion 6.topic: golang 6.topic: ruby 6.topic: vim 6.topic: erlang 6.topic: ocaml 6.topic: nodejs 6.topic: TeX Issues regarding texlive and TeX in general 6.topic: testing Tooling for automated testing of packages and modules 6.topic: module system About "NixOS" module system internals 6.topic: agda "A dependently typed programming language / interactive theorem prover" 6.topic: nim Nim programing language 6.topic: flakes The experimental Nix feature 6.topic: lib The Nixpkgs function library 6.topic: zig 6.topic: jupyter Interactive computing tooling: kernels, notebook, jupyterlab 6.topic: php 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 6.topic: k3s Kubernates distribution (https://k3s.io/) 6.topic: dotnet Language: .NET labels Jun 23, 2024
@PedroRegisPOAR
Copy link
Contributor Author

Sorry for the massive ping. It was by mistake.

It was a git push --force 🤦‍♂️

@NixOS NixOS locked and limited conversation to collaborators Jun 23, 2024
@K900 K900 closed this Jun 23, 2024
@K900
Copy link
Contributor

K900 commented Jun 23, 2024

Please resubmit the PR, as any further conversation here will mass ping people again.

@PedroRegisPOAR PedroRegisPOAR deleted the adds-glibcLocales-to-pycharm-community branch June 23, 2024 19:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants