Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extism-cli: 0.1.0 -> 0.3.8 #277606

Merged
merged 2 commits into from
Dec 31, 2023
Merged

extism-cli: 0.1.0 -> 0.3.8 #277606

merged 2 commits into from
Dec 31, 2023

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Dec 29, 2023

Use latest version and update for switch from Python to Go

Description of changes

  • Completely rewritten since version 0.1.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zshipko
Copy link
Contributor Author

zshipko commented Dec 30, 2023

I ended up having to remove the call to makeBinaryWrapper since the prefix argument isn't valid for all commands. Otherwise I think the suggestions have all been accounted for.

@zshipko zshipko force-pushed the update-extism-cli branch 2 times, most recently from 97d63be to 7a1b233 Compare December 30, 2023 23:29
@kirillrdy
Copy link
Member

@zshipko would you like to add yourself as maintainer ?

@zshipko
Copy link
Contributor Author

zshipko commented Dec 31, 2023

@zshipko would you like to add yourself as maintainer ?

Sure, just added myself as maintainer

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 31, 2023
@Janik-Haag Janik-Haag removed the request for review from piegamesde December 31, 2023 11:33
Copy link
Member

@Janik-Haag Janik-Haag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to include the full version so: extism-cli: 0.1.0 -> 0.3.8.

Also, thank you for your contribution <3

@Janik-Haag Janik-Haag changed the title extism-cli: 0.1 -> 0.3.8 extism-cli: 0.1.0 -> 0.3.8 Dec 31, 2023
@zshipko
Copy link
Contributor Author

zshipko commented Dec 31, 2023

Thank you for the review @Janik-Haag - I've updated with your suggestions!

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 31, 2023
@Janik-Haag Janik-Haag merged commit 3d54a95 into NixOS:master Dec 31, 2023
@zshipko zshipko deleted the update-extism-cli branch December 31, 2023 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants