Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gofumpt: 0.3.1 -> 0.5.0, refactor #274237

Merged
merged 5 commits into from
Dec 15, 2023
Merged

gofumpt: 0.3.1 -> 0.5.0, refactor #274237

merged 5 commits into from
Dec 15, 2023

Conversation

katexochen
Copy link
Contributor

@katexochen katexochen commented Dec 14, 2023 •
edited
Loading

Description of changes

Changelog v0.4.0: https://github.com/mvdan/gofumpt/releases/tag/v0.4.0
Changelog v0.5.0: https://github.com/mvdan/gofumpt/releases/tag/v0.5.0

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@katexochen katexochen requested a review from malt3 December 14, 2023 14:29
@ofborg ofborg bot added 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 14, 2023
malt3
malt3 approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@malt3 malt3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary works. Tested on Linux amd64.

@delroth delroth added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 14, 2023
@delroth delroth added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 14, 2023
@fabianhjr fabianhjr merged commit 395c332 into NixOS:master Dec 15, 2023
13 checks passed
@github-actions github-actions bot mentioned this pull request Dec 15, 2023
Closed
1 task
@github-actions GitHub Actions
Copy link
Contributor

Successfully created backport PR for release-23.11:

@katexochen katexochen deleted the gofumpt/0-5-0 branch December 15, 2023 15:54
This was referenced Jan 1, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malt3 malt3 malt3 approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees
No one assigned
Labels
6.topic: golang 8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@katexochen @malt3 @SuperSandro2000 @delroth @fabianhjr