Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

papilo: init at 2.3.0 #273295

Merged
merged 1 commit into from
Dec 16, 2024
Merged

papilo: init at 2.3.0 #273295

merged 1 commit into from
Dec 16, 2024

Conversation

david-r-cox
Copy link
Member

@david-r-cox david-r-cox commented Dec 10, 2023 •
edited
Loading

Description of changes

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.05 Release Notes (or backporting 23.05 and 23.11 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@david-r-cox
Copy link
Member Author

Result of nixpkgs-review pr 273295 run on x86_64-linux 1

1 package built:
  • papilo

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Dec 12, 2023
@david-r-cox david-r-cox mentioned this pull request Dec 14, 2023
Closed
13 tasks
@wegank wegank added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 4, 2024
@david-r-cox david-r-cox changed the title papilo: init at 2.1.4 papilo: init at 2.3.0 Aug 8, 2024
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 8, 2024
@david-r-cox david-r-cox force-pushed the papilo branch 3 times, most recently from 01847b4 to 1823555 Compare August 8, 2024 22:18
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Aug 9, 2024
AndersonTorres
AndersonTorres suggested changes Aug 23, 2024
View reviewed changes
pkgs/by-name/pa/papilo/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pa/papilo/package.nix Outdated Show resolved Hide resolved
eclairevoyant
eclairevoyant suggested changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@eclairevoyant eclairevoyant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To explain the above further, finalAttrs.pname should never be used in a URL (as it'd break when overriding pname) and lgpl3 is deprecated in favour of the Only/Plus variants.

@eclairevoyant
Copy link
Contributor

Build seems to be failing in CI but passes locally 🤔

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/1968

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Oct 29, 2024
@FliegendeWurst FliegendeWurst added the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Nov 11, 2024
@wegank wegank removed the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Nov 11, 2024
@FliegendeWurst FliegendeWurst merged commit 65a7676 into NixOS:master Dec 16, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eclairevoyant eclairevoyant eclairevoyant requested changes

@AndersonTorres AndersonTorres AndersonTorres approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12.approvals: 2 This PR was reviewed and approved by two reputable people
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@david-r-cox @eclairevoyant @nixos-discourse @AndersonTorres @FliegendeWurst @wegank