gscan2pdf: fix build failure, add patches #268836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pacien
approved these changes
Nov 21, 2023
delroth
added
12.approvals: 1
gador
force-pushed
the
gscan2pdf-libtiff-fix
branch
from
df8c4d3 to
5e959a0
Compare
Done 👍 |
delroth
removed
the
12.approvals: 1
pacien
approved these changes
Nov 22, 2023
delroth
added
the
12.approvals: 1
gador
force-pushed
the
gscan2pdf-libtiff-fix
branch
from
5e959a0 to
e9fd30d
Compare
Good catch, done 👍 |
delroth
removed
the
12.approvals: 1
pacien
approved these changes
Nov 22, 2023
delroth
added
the
12.approvals: 1
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/prs-already-reviewed/2617/1248 |
gador
force-pushed
the
gscan2pdf-libtiff-fix
branch
from
e9fd30d to
083bfd7
Compare
Due to the removal of tools like `tiff2pdf` from `libtiff` many tests fail or cause a timeout. This commit fixes the dependency to `libtiff_4_5`. fixes NixOS#268406 Signed-off-by: Florian Brandes <[email protected]>
Signed-off-by: Florian Brandes <[email protected]>
see https://sourceforge.net/p/gscan2pdf/bugs/421 Signed-off-by: Florian Brandes <[email protected]>
see: https://sourceforge.net/p/gscan2pdf/bugs/400 Signed-off-by: Florian Brandes <[email protected]>
gador
force-pushed
the
gscan2pdf-libtiff-fix
branch
from
083bfd7 to
d54a7a6
Compare
delroth
removed
the
12.approvals: 1
pacien
approved these changes
Nov 24, 2023
delroth
added
the
12.approvals: 1
|
Looks like this needs backporting to release-23.11: https://hydra.nixos.org/build/242651099 |
|
Successfully created backport PR for |
1 task
13 tasks
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Due to the removal of tools like
tiff2pdffromlibtiffmany tests fail or cause a timeout.This commit fixes the dependency to
libtiff_4_5. Also it includes two upstream patches, which haven't been merged and re-adds a previously removed test.fixes #268406
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)