Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wayqt: init at 0.2.0 #263965

Merged
merged 1 commit into from
Feb 6, 2024
Merged

wayqt: init at 0.2.0 #263965

merged 1 commit into from
Feb 6, 2024

Conversation

wineee
Copy link
Member

@wineee wineee commented Oct 28, 2023 •
edited
Loading

Description of changes

https://gitlab.com/desktop-frameworks/wayqt

dependencies for qtgreet and paper desktop （#195371 and #218112 ）

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@wineee wineee force-pushed the wayqt branch 2 times, most recently from 18b1aab to de3b480 Compare October 29, 2023 14:58
@ofborg ofborg bot added the 8.has: package (new) This PR adds a new package label Oct 29, 2023
@ofborg ofborg bot requested a review from Atemu October 29, 2023 15:23
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Oct 29, 2023
@marsam
Copy link
Contributor

marsam commented Feb 1, 2024

LGTM, please resolve the conflicts

Atemu
Atemu previously requested changes Feb 1, 2024
View reviewed changes
pkgs/development/libraries/wayqt/default.nix Outdated Show resolved Hide resolved
@wineee wineee changed the title wayqt: init at 0.1.99 wayqt: init at 0.2.0 Feb 2, 2024
@Atemu
Copy link
Member

Atemu commented Feb 2, 2024

Please squash.

@wineee wineee requested a review from Atemu February 6, 2024 01:58
@Atemu Atemu dismissed their stale review February 6, 2024 11:58

Wrong.

@Atemu Atemu merged commit 8d9b52d into NixOS:master Feb 6, 2024
23 checks passed
@wineee wineee deleted the wayqt branch February 6, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Atemu Atemu Atemu left review comments

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wineee @marsam @Atemu